Fix table sorting algorithm #41

Merged
timw4mail merged 5 commits from :fix-sort into develop 2022-01-07 17:04:19 -05:00
Contributor

Closes #40

Closes #40
colwellkr added 3 commits 2022-01-02 17:50:37 -05:00
timw4mail reviewed 2022-01-06 10:07:03 -05:00
@ -12,0 +9,4 @@
console.log("Comparing " + textA + " and " + textB)
if(th.classList.contains("numeric")){
arrayA = textA.replace('\n\t\t\t\t\t\tepisodes: ','').replace('-',0).split("/")
Owner

It's probably better to use the string trim method, so the whitespace doesn't matter.

It's probably better to use the string trim method, so the whitespace doesn't matter.
colwellkr added 1 commit 2022-01-07 13:32:02 -05:00
timw4mail/HummingBirdAnimeClient/pipeline/pr-develop This commit looks good Details
a0e6467f17
Removed whitespace from string.replace() call
Author
Contributor

For some reason string.trim() was not removing the whitespace, but limiting the replace to only episodes: allows parseInt to still work.

For some reason string.trim() was not removing the whitespace, but limiting the replace to only `episodes:` allows parseInt to still work.
timw4mail added 1 commit 2022-01-07 17:02:23 -05:00
timw4mail/HummingBirdAnimeClient/pipeline/pr-develop Build started... Details
42fa458058
Merge branch 'develop' into fix-sort
timw4mail merged commit 8c6706f7de into develop 2022-01-07 17:04:19 -05:00
timw4mail deleted branch fix-sort 2022-01-07 17:04:24 -05:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: timw4mail/HummingBirdAnimeClient#41
No description provided.