Browse Source

Misc bugfixes, especially for Anime without a MAL id.

pull/24/head
Timothy Warren 2 years ago
parent
commit
848f667626
  1. 5
      src/API/Anilist/Model.php
  2. 4
      src/Model/Anime.php
  3. 15
      src/Types/AbstractType.php

5
src/API/Anilist/Model.php

@ -274,6 +274,11 @@ final class Model
'type' => mb_strtoupper($type),
]);
if (empty($info) || empty($info['data']))
{
return NULL;
}
return (string)$info['data']['Media']['id'];
}
}

4
src/Model/Anime.php

@ -187,7 +187,7 @@ class Anime extends API {
$requester = new ParallelAPIRequest();
$requester->addRequest($this->kitsuModel->incrementListItem($data), 'kitsu');
if ($this->anilistEnabled && $data['mal_id'] !== null)
if (( ! empty($data['mal_id'])) && $this->anilistEnabled)
{
$requester->addRequest($this->anilistModel->incrementListItem($data, 'ANIME'), 'anilist');
}
@ -214,7 +214,7 @@ class Anime extends API {
$requester = new ParallelAPIRequest();
$requester->addRequest($this->kitsuModel->updateListItem($data), 'kitsu');
if ($this->anilistEnabled && $data['mal_id'] !== null)
if (( ! empty($data['mal_id'])) && $this->anilistEnabled)
{
$requester->addRequest($this->anilistModel->updateListItem($data, 'ANIME'), 'anilist');
}

15
src/Types/AbstractType.php

@ -17,8 +17,10 @@
namespace Aviat\AnimeClient\Types;
use ArrayAccess;
use ArrayObject;
use Countable;
abstract class AbstractType implements ArrayAccess {
abstract class AbstractType implements ArrayAccess, Countable {
/**
* Populate values for un-serializing data
*
@ -164,6 +166,17 @@ abstract class AbstractType implements ArrayAccess {
}
}
/**
* Implementing Countable
*
* @return int
*/
public function count(): int
{
$keys = array_keys($this->toArray());
return count($keys);
}
/**
* Recursively cast properties to an array
*

Loading…
Cancel
Save