timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Make sure Cast heading only shows up if there are actual cast entries

Browse Source
This commit is contained in:
Timothy Warren 2017-04-06 21:27:03 -04:00
parent b210954874
commit 81a1a927b1
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/character.php
View File

@ -72,7 +72,7 @@
<?php endif ?>
<section>
<?php if (array_key_exists('castings', $data['included'])): ?>
<?php if ($castCount > 0): ?>
<h3>Castings</h3>
<?php foreach($castings as $role => $entries): ?>
<h4><?= $role ?></h4>

26
src/Controller/Character.php
View File

@ -52,17 +52,25 @@ class Character extends BaseController {
$data[0]['attributes']['name']
),
'data' => $data,
'castCount' => 0,
'castings' => []
];
if (array_key_exists('included', $data) && array_key_exists('castings', $data['included']))
{
$viewData['castings'] = $this->organizeCast($data['included']['castings']);
$viewData['castCount'] = $this->getCastCount($viewData['castings']);
}
$this->outputHTML('character', $viewData);
}
/**
* Organize VA => anime relationships
*
* @param array $cast
* @return array
*/
private function dedupeCast(array $cast): array
{
$output = [];
@ -102,6 +110,24 @@ class Character extends BaseController {
return $output;
}
private function getCastCount(array $cast): int
{
$count = 0;
foreach($cast as $role)
{
if (
array_key_exists('attributes', $role) &&
array_key_exists('role', $role['attributes']) &&
( ! is_null($role['attributes']['role']))
) {
$count++;
}
}
return $count;
}
private function organizeCast(array $cast): array
{