timw4mail/HummingBirdAnimeClient
1
1
Fork 1
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Fix updating anime status when certain fields are empty
All checks were successful
timw4mail/HummingBirdAnimeClient/pipeline/pr-master This commit looks good
Details

Browse Source
This commit is contained in:
Timothy Warren 2020-10-07 15:30:42 -04:00
parent 24d6eaf0da
commit 238a423806
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/anime/edit.php
View File

@ -32,7 +32,7 @@
<td> <td>
<select name="watching_status" id="watching_status"> <select name="watching_status" id="watching_status">
<?php foreach($statuses as $status_key => $status_title): ?> <?php foreach($statuses as $status_key => $status_title): ?>
<option <?php if($item['watching_status'] === $status_key): ?>selected="selected"<?php endif ?> <option <?php if(strtolower($item['watching_status']) === $status_key): ?>selected="selected"<?php endif ?>
value="<?= $status_key ?>"><?= $status_title ?></option> value="<?= $status_key ?>"><?= $status_title ?></option>
<?php endforeach ?> <?php endforeach ?>
</select> </select>

19
src/AnimeClient/API/Kitsu/ListItem.php
View File

@ -143,16 +143,27 @@ final class ListItem extends AbstractListItem {
*/ */
public function update(string $id, FormItemData $data): Request public function update(string $id, FormItemData $data): Request
{ {
return $this->requestBuilder->mutateRequest('UpdateLibraryItem', [ // Data to always send
$updateData = [
'id' => $id, 'id' => $id,
'notes' => $data['notes'], 'notes' => $data['notes'],
'private' => (bool)$data['private'], 'private' => (bool)$data['private'],
'progress' => (int)$data['progress'],
'ratingTwenty' => (int)$data['ratingTwenty'],
'reconsumeCount' => (int)$data['reconsumeCount'], 'reconsumeCount' => (int)$data['reconsumeCount'],
'reconsuming' => (bool)$data['reconsuming'], 'reconsuming' => (bool)$data['reconsuming'],
'status' => strtoupper($data['status']), 'status' => strtoupper($data['status']),
]); ];
// Only send these variables if they have a value
if ($data['progress'] !== NULL)
{
$updateData['progress'] = (int)$data['progress'];
}
if ($data['ratingTwenty'] !== NULL)
{
$updateData['ratingTwenty'] = (int)$data['ratingTwenty'];
}
return $this->requestBuilder->mutateRequest('UpdateLibraryItem', $updateData);
} }
/** /**