Browse Source

Fix some scrutinizer issues

Timothy J. Warren 3 years ago
parent
commit
9b924c1424
4 changed files with 6 additions and 4 deletions
  1. 3
    1
      README.md
  2. 1
    1
      application/libraries/Page.php
  3. 1
    1
      application/libraries/Todo.php
  4. 1
    1
      application/views/task/edit.php

+ 3
- 1
README.md View File

@@ -1,3 +1,5 @@
1 1
 # Tim's Todo
2 2
 
3
-[![Build Status](https://travis-ci.org/timw4mail/tims-todo.svg?branch=master)](https://travis-ci.org/timw4mail/tims-todo)
3
+[![Build Status](https://travis-ci.org/timw4mail/tims-todo.svg?branch=master)](https://travis-ci.org/timw4mail/tims-todo)
4
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/timw4mail/tims-todo/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/timw4mail/tims-todo/?branch=master)
5
+[![Code Coverage](https://scrutinizer-ci.com/g/timw4mail/tims-todo/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/timw4mail/tims-todo/?branch=master)

+ 1
- 1
application/libraries/Page.php View File

@@ -241,7 +241,7 @@ class Page {
241 241
 	 *
242 242
 	 * Helper function for making script tags
243 243
 	 *
244
-	 * @param string $js
244
+	 * @param string $javascript
245 245
 	 * @param bool $domain
246 246
 	 * @return string
247 247
 	 */

+ 1
- 1
application/libraries/Todo.php View File

@@ -7,7 +7,7 @@
7 7
  */
8 8
 class Todo {
9 9
 
10
-	private $user, $pass, $email, $CI, $uid; //For user registration
10
+	private $user, $pass, $CI, $uid; //For user registration
11 11
 
12 12
 	/**
13 13
 	 * Constructor

+ 1
- 1
application/views/task/edit.php View File

@@ -100,7 +100,7 @@
100 100
 					<input type="radio" name="share_type" value="group" id="group_share" <?= (empty($selected_groups)) ? "": 'checked="checked"' ?> />
101 101
 				</dd>
102 102
 				<?php if( ! empty($friends)): ?>
103
-				<?php if($selected_friends === FALSE) {$selected_friends = array();} ?>
103
+				<?php if( ! is_array($selected_friends)) {$selected_friends = array();} ?>
104 104
 				<dt class="friend_share"><strong>Friend Settings</strong></dt>
105 105
 				<dd class="friend_share">
106 106
 					<dl>