From a767c75014789cd53dedf7e2202116a67fc905d6 Mon Sep 17 00:00:00 2001 From: Timothy J Warren Date: Wed, 29 Mar 2017 16:09:22 -0400 Subject: [PATCH] Make sure rating is only updated if it is numeric --- src/API/Kitsu/Transformer/AnimeListTransformer.php | 10 +++++----- src/API/Kitsu/Transformer/MangaListTransformer.php | 6 +++++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/API/Kitsu/Transformer/AnimeListTransformer.php b/src/API/Kitsu/Transformer/AnimeListTransformer.php index 0ecf35cd..9578a0c2 100644 --- a/src/API/Kitsu/Transformer/AnimeListTransformer.php +++ b/src/API/Kitsu/Transformer/AnimeListTransformer.php @@ -39,13 +39,13 @@ class AnimeListTransformer extends AbstractTransformer { $genres = array_column($anime['relationships']['genres'], 'name') ?? []; sort($genres); - + $rating = (int) 2 * $item['attributes']['rating']; $total_episodes = array_key_exists('episodeCount', $anime) && (int) $anime['episodeCount'] !== 0 ? (int) $anime['episodeCount'] : '-'; - + $MALid = NULL; if (array_key_exists('mappings', $anime['relationships'])) @@ -59,7 +59,7 @@ class AnimeListTransformer extends AbstractTransformer { } } } - + $streamingLinks = (array_key_exists('streamingLinks', $anime['relationships'])) ? Kitsu::parseListItemStreamingLinks($included, $animeId) : []; @@ -122,8 +122,8 @@ class AnimeListTransformer extends AbstractTransformer { 'private' => $privacy ] ]; - - if ( ! empty($item['user_rating'])) + + if (is_numeric($item['user_rating'])) { $untransformed['data']['rating'] = $item['user_rating'] / 2; } diff --git a/src/API/Kitsu/Transformer/MangaListTransformer.php b/src/API/Kitsu/Transformer/MangaListTransformer.php index 462702ae..209bb1c6 100644 --- a/src/API/Kitsu/Transformer/MangaListTransformer.php +++ b/src/API/Kitsu/Transformer/MangaListTransformer.php @@ -117,10 +117,14 @@ class MangaListTransformer extends AbstractTransformer { 'reconsuming' => $rereading, 'reconsumeCount' => (int)$item['reread_count'], 'notes' => $item['notes'], - 'rating' => $item['new_rating'] / 2 ], ]; + if (is_numeric($item['new_rating'])) + { + $map['data']['rating'] = $item['new_rating'] / 2; + } + return $map; } }