diff --git a/src/AnimeClient/Anilist.php b/src/AnimeClient/Anilist.php index 44277fba..7ddf0c6d 100644 --- a/src/AnimeClient/Anilist.php +++ b/src/AnimeClient/Anilist.php @@ -64,28 +64,4 @@ final class Anilist { MangaReadingStatus::DROPPED => KMRS::DROPPED, MangaReadingStatus::PLAN_TO_READ => KMRS::PLAN_TO_READ, ]; - - public static function getIdToWatchingStatusMap(): array - { - return [ - 'CURRENT' => AnimeWatchingStatus::WATCHING, - 'COMPLETED' => AnimeWatchingStatus::COMPLETED, - 'PAUSED' => AnimeWatchingStatus::ON_HOLD, - 'DROPPED' => AnimeWatchingStatus::DROPPED, - 'PLANNING' => AnimeWatchingStatus::PLAN_TO_WATCH, - 'REPEATING' => AnimeWatchingStatus::WATCHING, - ]; - } - - public static function getIdToReadingStatusMap(): array - { - return [ - 'CURRENT' => MangaReadingStatus::READING, - 'COMPLETED' => MangaReadingStatus::COMPLETED, - 'PAUSED' => MangaReadingStatus::ON_HOLD, - 'DROPPED' => MangaReadingStatus::DROPPED, - 'PLANNING' => MangaReadingStatus::PLAN_TO_READ, - 'REPEATING' => MangaReadingStatus::READING, - ]; - } } \ No newline at end of file diff --git a/src/AnimeClient/MenuGenerator.php b/src/AnimeClient/MenuGenerator.php index 65e5a98c..d26e2af1 100644 --- a/src/AnimeClient/MenuGenerator.php +++ b/src/AnimeClient/MenuGenerator.php @@ -49,15 +49,7 @@ final class MenuGenerator extends UrlGenerator { */ public static function new(ContainerInterface $container): self { - try - { - return new static($container); - } - catch (\Throwable $e) - { - dump($e); - die(); - } + return new self($container); } /** @@ -67,7 +59,7 @@ final class MenuGenerator extends UrlGenerator { * @throws ConfigException * @return string */ - public function generate($menu) : string + public function generate(string $menu) : string { $menus = $this->config->get('menus'); $parsedConfig = $this->parseConfig($menus); diff --git a/src/AnimeClient/UrlGenerator.php b/src/AnimeClient/UrlGenerator.php index 61ac230d..ab94dc52 100644 --- a/src/AnimeClient/UrlGenerator.php +++ b/src/AnimeClient/UrlGenerator.php @@ -110,7 +110,9 @@ class UrlGenerator extends RoutingBase { if ($defaultPath !== NULL) { + // @codeCoverageIgnoreStart return $this->url("{$type}/{$defaultPath}"); + // @codeCoverageIgnoreEnd } throw new InvalidArgumentException("Invalid default type: '{$type}'"); diff --git a/tests/AnimeClient/UrlGeneratorTest.php b/tests/AnimeClient/UrlGeneratorTest.php index 9e9da549..ab388d91 100644 --- a/tests/AnimeClient/UrlGeneratorTest.php +++ b/tests/AnimeClient/UrlGeneratorTest.php @@ -18,6 +18,7 @@ namespace Aviat\AnimeClient\Tests; use Aviat\AnimeClient\UrlGenerator; use Aviat\Ion\Config; +use Aviat\Ion\Exception\DoubleRenderException; class UrlGeneratorTest extends AnimeClientTestCase { @@ -49,4 +50,14 @@ class UrlGeneratorTest extends AnimeClientTestCase { $result = $urlGenerator->assetUrl(...$args); $this->assertEquals($expected, $result); } + + public function testDefaultUrlInvalidType(): void + { + $this->expectException(\InvalidArgumentException::class); + $this->expectExceptionMessage("Invalid default type: 'foo'"); + + $urlGenerator = new UrlGenerator($this->container); + $url = $urlGenerator->defaultUrl('foo'); + + } } \ No newline at end of file