From 5357bfb12240bdccab557a832872a5699ab8a701 Mon Sep 17 00:00:00 2001 From: Timothy J Warren Date: Thu, 6 Apr 2017 14:53:38 -0400 Subject: [PATCH] Make sure rating parameter sent to Kitsu is greater than 0 --- src/API/Kitsu/Transformer/AnimeListTransformer.php | 2 +- .../Kitsu/Transformer/AnimeListTransformerTest.php | 13 +++++++++++++ ...merTest__testUntransform with data set #2__1.php | 13 +++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 tests/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set #2__1.php diff --git a/src/API/Kitsu/Transformer/AnimeListTransformer.php b/src/API/Kitsu/Transformer/AnimeListTransformer.php index 9578a0c2..c6fee55d 100644 --- a/src/API/Kitsu/Transformer/AnimeListTransformer.php +++ b/src/API/Kitsu/Transformer/AnimeListTransformer.php @@ -123,7 +123,7 @@ class AnimeListTransformer extends AbstractTransformer { ] ]; - if (is_numeric($item['user_rating'])) + if (is_numeric($item['user_rating']) && $item['user_rating'] > 0) { $untransformed['data']['rating'] = $item['user_rating'] / 2; } diff --git a/tests/API/Kitsu/Transformer/AnimeListTransformerTest.php b/tests/API/Kitsu/Transformer/AnimeListTransformerTest.php index 39c07430..e8a20e63 100644 --- a/tests/API/Kitsu/Transformer/AnimeListTransformerTest.php +++ b/tests/API/Kitsu/Transformer/AnimeListTransformerTest.php @@ -68,6 +68,19 @@ class AnimeListTransformerTest extends AnimeClientTestCase { 'private' => 'On', 'rewatching' => 'On' ] + ], [ + 'input' => [ + 'id' => 14047983, + 'mal_id' => '12347', + 'watching_status' => 'current', + 'user_rating' => 0, + 'episodes_watched' => 12, + 'rewatched' => 0, + 'notes' => '', + 'edit' => 'true', + 'private' => 'On', + 'rewatching' => 'On' + ] ]]; } diff --git a/tests/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set #2__1.php b/tests/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set #2__1.php new file mode 100644 index 00000000..79fc5db2 --- /dev/null +++ b/tests/API/Kitsu/Transformer/__snapshots__/AnimeListTransformerTest__testUntransform with data set #2__1.php @@ -0,0 +1,13 @@ + 14047983, + 'mal_id' => '12347', + 'data' => + array ( + 'status' => 'current', + 'reconsuming' => true, + 'reconsumeCount' => 0, + 'notes' => '', + 'progress' => 12, + 'private' => true, + ), +);